Escape invalid XML chars in testCase and testSuite names #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #285
With a ParameterizedTest it is possible to generate test case names with invalid XML characters. E.g.
The test case name is derived from the input string, which in this case contains an invalid XML char
\b
. When tools (like IDEs) try to parse the junit XML, they'll fail due to the invalid char.Fix it by escaping test case names. It looks like test suite names could also contain invalid XML chars, so I'm escaping those as well.